Skip to content

chore: app start time improvement (#WPB-14874) #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

chore: app start time improvement (#WPB-14874) #4041

merged 1 commit into from
Jul 15, 2025

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented May 27, 2025 •
edited by github-actions bot
Loading

BugWPB-14874 [Android] White screen after putting wire to background and opening other applications on older devices

https://wearezeta.atlassian.net/browse/WPB-14874

What's new in this PR?

Issues

Issue described in the ticket is caused by slow cold start.

Causes (Optional)

The application start time issue needs more investigation. This PR fixes one issue with the lazy initialization of the CoreLogic.

Solutions

Use Lazy for deferred initialization of CoreLogic. This decreased the cold start time on my Samsung A22 by ~1 second and fixed one StrictMode warning for IO operation on main thread during app start.

@sbakhtiarov sbakhtiarov requested a review from MohamadJaara May 27, 2025 11:42
@sbakhtiarov sbakhtiarov requested a review from yamilmedina May 27, 2025 11:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented May 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 47.61%. Comparing base (6c8195c) to head (64a15d2).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...otlin/com/wire/android/ui/WireActivityViewModel.kt 50.00% 4 Missing ⚠️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 90.90% 2 Missing ⚠️
...ialog/deactivated/LegalHoldDeactivatedViewModel.kt 60.00% 1 Missing and 1 partial ⚠️
...otlin/com/wire/android/ui/CallFeedbackViewModel.kt 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #4041   +/-   ##
========================================
  Coverage    47.61%   47.61%           
========================================
  Files          509      509           
  Lines        17812    17812           
  Branches      2925     2925           
========================================
  Hits          8481     8481           
  Misses        8449     8449           
  Partials       882      882
Files with missing lines Coverage Δ
...re/android/ui/analytics/AnalyticsUsageViewModel.kt 93.10% <100.00%> (ø)
...wire/android/ui/home/drawer/HomeDrawerViewModel.kt 93.18% <100.00%> (ø)
...ld/dialog/requested/LegalHoldRequestedViewModel.kt 88.88% <100.00%> (ø)
...otlin/com/wire/android/ui/CallFeedbackViewModel.kt 90.12% <94.44%> (ø)
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 57.69% <90.90%> (ø)
...ialog/deactivated/LegalHoldDeactivatedViewModel.kt 82.05% <60.00%> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 74.30% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8195c...64a15d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

@github-actions github-actions bot added the stale Inactivity alert label Jun 27, 2025
@stale stale bot removed the stale Inactivity alert label Jul 4, 2025
MohamadJaara
MohamadJaara approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbakhtiarov sbakhtiarov force-pushed the chore/app-start-time branch 2 times, most recently from bbf85d5 to 96f5735 Compare July 15, 2025 07:47
@sbakhtiarov sbakhtiarov enabled auto-merge July 15, 2025 07:51
@sbakhtiarov sbakhtiarov force-pushed the chore/app-start-time branch from 96f5735 to 1adb09d Compare July 15, 2025 13:03
@sbakhtiarov
chore: app start time improvement (#WPB-14874)
64a15d2 
feat: add use case to observe Message [WPB-18248] (#3511)

* feat: add Message and ConversationDetailsWithEvents observe use cases [WPB-18248]

* detekt

* remove ObserveConversationDetailsWithEventsUseCase and related methods

* remove ObserveConversationDetailsWithEventsUseCase and related methods

* remove ObserveConversationDetailsWithEventsUseCase and related methods
@sbakhtiarov sbakhtiarov force-pushed the chore/app-start-time branch from 1adb09d to 64a15d2 Compare July 15, 2025 13:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Jul 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4041.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4041.apk is available for download

Merged via the queue into develop with commit 4a3568e Jul 15, 2025
12 of 13 checks passed
@sbakhtiarov sbakhtiarov deleted the chore/app-start-time branch July 15, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@saleniuk saleniuk saleniuk approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

Assignees

@sbakhtiarov sbakhtiarov

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbakhtiarov @MohamadJaara @saleniuk